Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ProBuilder Highlight OverFlow #158

Merged
merged 25 commits into from
Feb 19, 2024
Merged

fix: ProBuilder Highlight OverFlow #158

merged 25 commits into from
Feb 19, 2024
+6,460 −5,192

Conversation

rdmclin2
Copy link
Member

@rdmclin2 rdmclin2 commented Feb 2, 2024 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

  • 修复 Highlight 组件变更导致的滚动问题。
  • Highlight 支持关闭 shiki 模式，默认开启。
  • 去掉 Highlight wrapper 模式，直接集成到 Markdown 组件中。
  • ActionGroup 去掉默认的按钮集成，没有多大意义。
  • 统一所有文档格式，重新生成英文文档。

📝 补充信息 | Additional Information

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

🎊 PR Preview 5c290bd has been successfully built and deployed to https://ant-design-pro-editor-preview-pr-158.surge.sh

🕐 Build time: 62.831s

🤖 By surge-preview

@rdmclin2 rdmclin2 changed the title fix: ProBuilder Highlight OverFlow [WIP]: fix: ProBuilder Highlight OverFlow Feb 2, 2024
@rdmclin2 rdmclin2 changed the title [WIP]: fix: ProBuilder Highlight OverFlow fix: ProBuilder Highlight OverFlow Feb 9, 2024
@canisminor1990
Copy link
Member

大哥 过年了

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 89.86569% with 83 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (8c631b1) to head (5c290bd).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
docs/pro-editor/demos/buttonAsset/format.ts 0.00% 28 Missing ⚠️
docs/pro-editor/demos/buttonAsset/codeEmitter.tsx 0.00% 27 Missing ⚠️
src/ActionGroup/demos/_items.tsx 90.47% 8 Missing ⚠️
docs/guide/demos/ColumnList/index.tsx 0.00% 6 Missing ⚠️
docs/pro-editor/demos/buttonAsset/index.ts 0.00% 3 Missing ⚠️
src/ColumnList/demos/controlled.tsx 77.77% 2 Missing ⚠️
src/ColumnList/demos/customCreate.tsx 77.77% 2 Missing ⚠️
src/ProBuilder/components/Code/index.tsx 0.00% 2 Missing ⚠️
docs/pro-editor/demos/buttonAssets.tsx 0.00% 1 Missing ⚠️
docs/pro-editor/demos/defaultAssets.tsx 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   81.02%   81.06%   +0.03%     
==========================================
  Files         356      360       +4     
  Lines       23471    23381      -90     
  Branches     1028     1041      +13     
==========================================
- Hits        19018    18953      -65     
+ Misses       4453     4428      -25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ONLY-yours
Copy link
Collaborator

ONLY-yours commented Feb 19, 2024 •
edited
Loading

大哥 过年了

@canisminor1990
「只有过年能写点自己的代码」他是这么说的 哈哈哈

@ONLY-yours ONLY-yours merged commit a557dce into main Feb 19, 2024
5 checks passed
@ONLY-yours ONLY-yours deleted the fix/highlight-overflow branch February 19, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ONLY-yours ONLY-yours ONLY-yours approved these changes

@arvinxx arvinxx Awaiting requested review from arvinxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdmclin2 @canisminor1990 @codecov-commenter @ONLY-yours